Skip to content

Hackathon 2025 - Cumulative changes#1496

Merged
tommartensen merged 38 commits intomasterfrom
dv/final-touches
Mar 4, 2025
Merged

Hackathon 2025 - Cumulative changes#1496
tommartensen merged 38 commits intomasterfrom
dv/final-touches

Conversation

@dvail
Copy link
Copy Markdown
Contributor

@dvail dvail commented Feb 26, 2025

Change overview

  1. PatternFly 4 -> 6 upgrade in place along side Tailwind components
  2. Replacement of TailwindCSS with PF components entirely, keeping UX almost identical
  3. Drop extraneous dependencies (Tailwind, PostCSS, react-feather, and more)
  4. Replace create-react-app/react-scripts with vite
  5. Add @tanstack/react-query
  6. Replace most existing GET query code with react-query to add caching/prefetching
  7. Dark mode

Testing

Load the home page, with some simulated data to view all possible flavor states.
image

Show all flavors and clusters:
image

Create a cluster:
image
image
image

Increment/decrement lifespan:
image

View artifacts for a ready cluster, + copy command:
image

Download binaries:
image

Dark mode:
image

404:
image

Logout (changes to the style of the login page maybe at the next Hackathon):
image

@dvail dvail requested a review from a team as a code owner February 26, 2025 21:32
@dvail
Copy link
Copy Markdown
Contributor Author

dvail commented Feb 26, 2025

@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Feb 26, 2025

A single node development cluster (infra-pr-1496) was allocated in production infra for this PR.

CI will attempt to deploy quay.io/rhacs-eng/infra-server:0.10.73-38-ge1af8f61e0 to it.

🔌 You can connect to this cluster with:

gcloud container clusters get-credentials infra-pr-1496 --zone us-central1-a --project acs-team-temp-dev

🛠️ And pull infractl from the deployed dev infra-server with:

nohup kubectl -n infra port-forward svc/infra-server-service 8443:8443 &
make pull-infractl-from-dev-server

🚲 You can then use the dev infra instance e.g.:

bin/infractl -k -e localhost:8443 whoami

⚠️ Any clusters that you start using your dev infra instance should have a lifespan shorter then the development cluster instance. Otherwise they will not be destroyed when the dev infra instance ceases to exist when the development cluster is deleted. ⚠️

Further Development

☕ If you make changes, you can commit and push and CI will take care of updating the development cluster.

🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:

make install-local

Logs

Logs for the development infra depending on your @redhat.com authuser:

Or:

kubectl -n infra logs -l app=infra-server --tail=1 -f

@dvail dvail changed the base branch from dv/dark-mode to master February 27, 2025 16:39
@dvail dvail changed the title Re-add drawer layout Hackathon 2025 - Cumulative changes Feb 27, 2025
Copy link
Copy Markdown
Contributor

@davdhacs davdhacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yolo :)

"@patternfly/react-icons": "^6.0.0",
"@tanstack/react-query": "^5.66.9",
"axios": "^0.21.4",
"eslint": "^7.11.0",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add eslint explicitly after dropping react-scripts.

"react": "^17.0.1",
"react-dom": "^17.0.1",
"react-feather": "^2.0.9",
"random-words": "^2.0.1",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

random-words is a replacement for namor used to generate random cluster names. The latter used the node crypto module, and was making the build process more cumbersome after moving to vite.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly an auto-generated configuration from the cra->vite migration tool: npx viject.

@tommartensen tommartensen merged commit 2286a29 into master Mar 4, 2025
10 checks passed
@tommartensen tommartensen deleted the dv/final-touches branch March 4, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants